Updating TransportSimulateIndexTemplateAction.resolveTemplate() to account for data stream overrides #132131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count for data stream overrides
masseyke
added
>bug
:Data Management/Indices APIs
|
Hi @masseyke, I've created a changelog YAML for you. |
…e' of github.com:masseyke/elasticsearch into fix/TransportSimulateIndexTemplateAction-resolveTemplate
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
|
Hi @masseyke, I've updated the changelog YAML for you. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the simulate index template API to properly account for data stream mapping and setting overrides. The core issue was that when simulating templates for data streams, the API wasn't considering the overrides that had been applied to the data stream, leading to inaccurate simulation results.
Key changes:
- Modified
resolveTemplate()method to accept an additionalProjectMetadataparameter for accessing actual project data - Added logic to retrieve and apply data stream mapping and setting overrides when the template is for a data stream
- Updated all callers of
resolveTemplate()to provide the new parameter
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TransportSimulateIndexTemplateAction.java | Core fix - adds data stream override logic to resolveTemplate() method |
| TransportSimulateBulkAction.java | Updated to pass actual project metadata to resolveTemplate() |
| TransportSimulateTemplateAction.java | Updated to pass project metadata (with explanatory comment) |
| TransportSimulateIndexTemplateActionTests.java | Updated test to provide new parameter |
| 10_basic.yml | Added integration test for data stream overrides |
| 80_ingest_simulate.yml | Added test for ingest simulation with data stream mapping overrides |
| 132131.yaml | Changelog entry for the bug fix |
...g/elasticsearch/action/admin/indices/template/post/TransportSimulateIndexTemplateAction.java
Outdated
Show resolved
Hide resolved
...g/elasticsearch/action/admin/indices/template/post/TransportSimulateIndexTemplateAction.java
Outdated
Show resolved
Hide resolved
...g/elasticsearch/action/admin/indices/template/post/TransportSimulateIndexTemplateAction.java
Outdated
Show resolved
Hide resolved
dakrone
approved these changes
Aug 11, 2025
| ); | ||
| } | ||
|
|
||
| private static List<CompressedXContent> collectMappings( |
There was a problem hiding this comment.
Can you add javadocs for this method?
| private static Settings collectSettings( | ||
| final ProjectMetadata simulatedProject, | ||
| final DataStream dataStream, | ||
| String templateNmae, |
There was a problem hiding this comment.
Minor typo: templateNmae -> templateName
masseyke
added
the
auto-backport
masseyke
deleted the
fix/TransportSimulateIndexTemplateAction-resolveTemplate
branch
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
Removing the backport labels because data stream settings did not appear until 9.2.0. |
masseyke
added
v9.2.0
>non-issue
and removed
backport pending
auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #131425, the simulate index API does not account for data stream mapping overrides. It also does not account for data stream setting overrides. Here is how it impacts the simulate APIs:
_index_template/_simulate_index/{index_name})_ingest/_simulate)_index_template/_simulate)_ingest/pipeline)This PR fixes TransportSimulateIndexTemplateAction.resolveTemplate() by reading the data stream for the index (if it exists) in a new ProjectMetadata argument. It adds the data stream's mapping and setting overrides to the template it is creating.
Closes #131425