Multiple utilization samples in write load decider #132148
Conversation
…e_decider # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
| newUtilizationSamples.add( | ||
| new NodeUsageStatsForThreadPools.UtilizationSample(previousUtilization.instant(), newWritePoolUtilization) | ||
| ); | ||
| return new NodeUsageStatsForThreadPools.ThreadPoolUsageStats(writeThreadPoolStats.numberOfThreads(), newUtilizationSamples); |
There was a problem hiding this comment.
Simulator will replace the most recent utilization value with the new one. We could instead add one to the end, but then what timestamp would we put on it? 🤷
Hard to know the best strategy without knowing how the determination of "hot spotting" is made, and whether we care about that in the simulator.
There was a problem hiding this comment.
I think hot-spot detection should be same for real data and simulation. How about simulate samples? Maybe apply fixed value to all of them and then run hot-spot detection?
nicktindall
added
>non-issue
:Distributed Coordination/Allocation
| public record UtilizationSample(Instant instant, float utilization) implements Writeable { | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { |
There was a problem hiding this comment.
There were equals, hashCode and toString methods on these records, I'm not sure if they were once classes or we're doing something special here? I removed them in lieu of the ones you get for free with a record.
nicktindall
changed the title
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
4 participants
Change ClusterInfo to contain a list of utilization samples rather than a single one.
I decided not to include the information about hot spotting in this, because it's hard to imagine what it'll look like without having done the work to calculate it & interpret it.
Happy to add it if we think we are set on what that looks like.