Clarify flush result when skipped due to collision #132163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unclear boolean flag before was easy to misinterpret. This PR clarifies the boolean flag better, to understand that it details to whether a flush request was skipped due to collisions or not (rather than the flush request being performed or not).
kingherc
added
>non-issue
:Distributed Indexing/Engine
elasticsearchmachine
added
the
serverless-linked
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
fcofdez
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unclear boolean flag before was easy to misinterpret. This PR clarifies the boolean flag better, instigated from this comment, to understand that it details to whether a flush request was skipped due to collisions or not (rather than the flush request being performed or not).