Skip to content

ESQL: Fix StdDev test for NaN results #132195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

ESQL: Fix StdDev test for NaN results #132195

merged 1 commit into from
Jul 31, 2025

Conversation

ivancea
Copy link
Contributor

@ivancea ivancea commented Jul 30, 2025

Failed in CI, reproducible with the test and seed:

gradlew":x-pack:plugin:esql:test" --tests "org.elasticsearch.xpack.esql.expression.function.aggregate.StdDevTests.testAggregate {TestCase=<double> #4}" -Dtests.seed=3B09675353FB805D

@ivancea ivancea requested a review from limotova July 30, 2025 15:47
@ivancea ivancea added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.2.0 v9.1.1 v8.19.1 v9.0.5 v8.18.5 labels Jul 30, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

limotova
limotova approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@limotova limotova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ivancea ivancea enabled auto-merge (squash) July 31, 2025 07:36
@ivancea ivancea merged commit 3dc75ff into elastic:main Jul 31, 2025
33 checks passed
@ivancea ivancea deleted the esql-fix-test-stddev branch July 31, 2025 08:35
This was referenced Jul 31, 2025
Merged
Merged
Merged
ivancea added a commit to ivancea/elasticsearch that referenced this pull request Jul 31, 2025
@ivancea
ESQL: Fix StdDev test for NaN results (elastic#132195)
0c03f6a
@ivancea ivancea mentioned this pull request Jul 31, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.1
✅ 8.19
✅ 9.0
✅ 8.18

ivancea added a commit to ivancea/elasticsearch that referenced this pull request Jul 31, 2025
@ivancea
ESQL: Fix StdDev test for NaN results (elastic#132195)
ef3a29f
ivancea added a commit to ivancea/elasticsearch that referenced this pull request Jul 31, 2025
@ivancea
ESQL: Fix StdDev test for NaN results (elastic#132195)
9ae40e2
ivancea added a commit to ivancea/elasticsearch that referenced this pull request Jul 31, 2025
@ivancea
ESQL: Fix StdDev test for NaN results (elastic#132195)
e547f31
elasticsearchmachine pushed a commit that referenced this pull request Jul 31, 2025
@ivancea
ESQL: Fix StdDev test for NaN results (#132195) (#132245)
10a8af2
elasticsearchmachine pushed a commit that referenced this pull request Jul 31, 2025
@ivancea
ESQL: Fix StdDev test for NaN results (#132195) (#132248)
c023d56
elasticsearchmachine pushed a commit that referenced this pull request Jul 31, 2025
@ivancea
ESQL: Fix StdDev test for NaN results (#132195) (#132247)
2225627
elasticsearchmachine pushed a commit that referenced this pull request Jul 31, 2025
@ivancea
ESQL: Fix StdDev test for NaN results (#132195) (#132246)
3736807
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jul 31, 2025
@ivancea @smalyshev
ESQL: Fix StdDev test for NaN results (elastic#132195)
f1e9a7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@limotova limotova limotova approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.5 v8.19.1 v9.0.5 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivancea @elasticsearchmachine @limotova