[ML][Transform] Move upgrade mode check into API #132198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transform and ML's System Index Migration code uses deprecated API to access the ClusterState. Rather than refactor all System Index Migration logic to depend on ProjectState, we can move those checks into the API layer and perform them there. Both API now return alreadyInUpgradeMode if the API exits early for that reason.
prwhelan
added
>refactoring
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
SystemIndexMigrator will be project aware soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform and ML's System Index Migration code uses deprecated API to access the ClusterState. Rather than refactor all System Index Migration logic to depend on ProjectState, we can move those checks into the API layer and perform them there.
Both API now return alreadyInUpgradeMode if the API exits early for that reason.