Skip to content

Conversation

@martijnvg
Copy link
Member

No description provided.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Contributor

@parkertimmins parkertimmins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jordan-powers jordan-powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one note about the calculation, but overall the rest LGTM

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Martijn!

@martijnvg martijnvg enabled auto-merge (squash) August 1, 2025 03:15
@martijnvg martijnvg merged commit a2eeea4 into elastic:main Aug 1, 2025
33 checks passed
@serenachou
Copy link
Contributor

awesome thank you @martijnvg

martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Aug 7, 2025
By simulating what `FixedBitSet` exactly does.
This also improves testing because we can compare against `FixedBitSet#ramBytesUsed()`.

Follow up from #elastic#132232
martijnvg added a commit that referenced this pull request Aug 8, 2025
By simulating what `FixedBitSet` exactly does.
This also improves testing because we can compare against `FixedBitSet#ramBytesUsed()`.

Follow up from #132232
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 15, 2025
* upstream/main: (822 commits)
  Improve Semantic Text Exists Query Tests (elastic#132283)
  Make hierarchical k-means over centroids cheaper (elastic#132316)
  Remove unnecessary listener.delegateFailure in IndexShard#ensureMutable (elastic#132294)
  Add missing release note (elastic#132319)
  Unmute elastic#131803 (elastic#132295)
  Include bytes for live docs in ShardFieldStats (elastic#132232)
  Fix default missing index sort value of data_nanos pre 7.14 (elastic#132162)
  [DiskBBQ] Quantize centroids using 7 bits instead of 4 bits (elastic#132261)
  Use panamized version for windows in Int7VectorScorer (elastic#132311)
  Mute org.elasticsearch.xpack.ml.integration.AutodetectMemoryLimitIT testTooManyByAndOverFields elastic#132310
  Mute org.elasticsearch.xpack.ml.integration.AutodetectMemoryLimitIT testManyDistinctOverFields elastic#132308
  Update 8.17 version to 8.17.10 (elastic#132303)
  Mute org.elasticsearch.datastreams.DataStreamsClientYamlTestSuiteIT test {p0=data_stream/10_basic/Create hidden data stream with match all template} elastic#132298
  Add random queries to logsdb data generation tests (elastic#132109)
  ES|QL Inference runner refactoring (elastic#131986)
  Add basic example to linear-retriever.md (elastic#132196)
  Refactor RemoteClusterService to be multi-project aware (elastic#131894)
  ESQL: Mark csv-spec tests (elastic#132098)
  Mute org.elasticsearch.common.logging.JULBridgeTests testThrowable elastic#132280
  Bump versions after 8.19.0 release
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants