Remove unnecessary fold in enrich policy name #132239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
approved these changes
Aug 1, 2025
Comment on lines
112
to
113
|
|
||
| private static String asString(Expression expression) { |
There was a problem hiding this comment.
In this PR, Julian is adding this function to the Foldables class: https://github.com/elastic/elasticsearch/pull/131870/files#diff-dbc8ae6bfd90922dda68e61b020be920e8514b5870a999e8c85923f7e3f6d3a7R20-R25
I would move this there, to have a conflict later and avoid repeated functionality. As the error string is different, maybe having an overload accepting the error?
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes a folding todo from EsqlSession around retrieving enrich policy name/