Concurrent lookup index resolution #132242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change attempts to resolve lookup indices concurrently.
idegtiarenko
added
>non-issue
Team:Analytics
alex-spies
reviewed
Jul 31, 2025
There was a problem hiding this comment.
I think the change makes sense, but I'm not familiar enough with our listener pipeline here to check for unintended consequences. I see you also seek review from @astefan , which is a good idea IMO as he's more familiar here.
| } | ||
| ) | ||
| // first resolve the lookup indices, then the main indices | ||
| .<PreAnalysisResult>andThen((l, preAnalysisResult) -> { |
There was a problem hiding this comment.
A comment wouldn't hurt to make more clear that this runs for all lookup indices in parallel.
astefan
approved these changes
Aug 6, 2025
|
Outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change attempts to resolve lookup indices concurrently.
Opening as a draft to discuss feasibility and practicality of such approach.
In theory this could decrease analysis time for a queries using multiple lookup joins.