Skip to content

ESQL: Fix Driver creating status with a live list of operators #132260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 1, 2025
Merged

ESQL: Fix Driver creating status with a live list of operators #132260

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fbf7606
ESQL: FIx Driver creating status with a live list of operators
ivancea Jul 31, 2025
9a464cc
Update docs/changelog/132260.yaml
ivancea Jul 31, 2025
961164c
Use List.copyOf() and add test
ivancea Jul 31, 2025
8cb50f8
Merge branch 'main' into fix-esql-driver-status-concurrency
ivancea Jul 31, 2025
0110c99
[CI] Auto commit changes from spotless
Jul 31, 2025
7f2a769
Merge branch 'main' into fix-esql-driver-status-concurrency
ivancea Jul 31, 2025
a5153d2
Merge branch 'main' into fix-esql-driver-status-concurrency
ivancea Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/132260.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 132260
summary: FIx Driver creating status with a live list of operators
area: ES|QL
type: bug
issues:
- 131564
2 changes: 1 addition & 1 deletion x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Driver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ private void updateStatus(long extraCpuNanos, int extraIterations, DriverStatus.
prev.cpuNanos() + extraCpuNanos,
prev.iterations() + extraIterations,
status,
statusOfCompletedOperators,
new ArrayList<>(statusOfCompletedOperators),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably do List.copyOf here, but this is fine.

I think it's worth a comment that we always update the statusOfCompletedOperators list in this thread, but we read it in many threads.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the suggestion, and a test.

About the statusOfCompletedOperators, after this change, it's never read outside of the updateStatus()

activeOperators.stream().map(op -> new OperatorStatus(op.toString(), op.status())).toList(),
sleeps
);
Expand Down