Skip to content

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jul 31, 2025

This replaces the explicit tagging of timeseries = true on time series aggregations with a scan of the combine method. This is a step towards supporting many inputs to aggs universally.

Relates to #108385

This replaces the explicit tagging of `timeseries = true` on time series
aggregations with a scan of the `combine` method. This is a step towards
supporting many inputs to aggs universally.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 31, 2025
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nik!

Copy link
Contributor

@limotova limotova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nik9000 nik9000 merged commit 78b63ff into elastic:main Aug 1, 2025
33 checks passed
@przemekwitek
Copy link
Contributor

Thanks for working on this as this is also a prerequisite for my #132255 (sort VALUES by timestamp).
Do you think the timestamps can now be made easily accessible in ValuesLongAggregatorFunction and others? Or is it some more foundational work needed for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants