-
Notifications
You must be signed in to change notification settings - Fork 25.7k
ESQL: Detect time series agg #132287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESQL: Detect time series agg #132287
Conversation
This replaces the explicit tagging of `timeseries = true` on time series aggregations with a scan of the `combine` method. This is a step towards supporting many inputs to aggs universally.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Nik!
limotova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thanks for working on this as this is also a prerequisite for my #132255 (sort VALUES by timestamp). |
This replaces the explicit tagging of
timeseries = trueon time series aggregations with a scan of thecombinemethod. This is a step towards supporting many inputs to aggs universally.Relates to #108385