Skip to content

Simulate API: Remove invalid processors REST test #132325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szybia merged 3 commits into from
Aug 19, 2025
Merged

Simulate API: Remove invalid processors REST test #132325

szybia merged 3 commits into from
Aug 19, 2025

Conversation

@szybia
Copy link
Contributor

@szybia szybia commented Aug 1, 2025 •
edited
Loading

  • Remove a test that tests for a bug that returns a 500, and fails rest-compatibility in my fix PR in 9.2

@szybia szybia changed the title Simulate API: Mute invalid processors BCC test Simulate API: Skip invalid processors BCC test Aug 1, 2025
@szybia szybia added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Aug 15, 2025
@szybia szybia changed the title Simulate API: Skip invalid processors BCC test Simulate API: Remove invalid processors BCC test Aug 15, 2025
@szybia szybia marked this pull request as ready for review August 15, 2025 12:13
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Aug 15, 2025

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Aug 15, 2025
PeteGillinElastic
PeteGillinElastic approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@PeteGillinElastic PeteGillinElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can't see any benefit in keeping a test on 8.x that asserts the buggy behaviour.

@PeteGillinElastic
Copy link
Member

PeteGillinElastic commented Aug 15, 2025

Nit: I think you mean BWC (backwards compatibility) rather than BCC (breaking changes committee).

@PeteGillinElastic
Copy link
Member

PeteGillinElastic commented Aug 15, 2025

Although also you're not removing a BCC test, you're just removing a test which fails REST compat downstream... (N.B. BWC tests and REST compat tests are two different things.)

@szybia szybia changed the title Simulate API: Remove invalid processors BCC test Simulate API: Remove invalid processors REST test Aug 15, 2025
@szybia szybia enabled auto-merge (squash) August 15, 2025 13:04
@szybia szybia merged commit 37293f0 into elastic:8.19 Aug 19, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeteGillinElastic PeteGillinElastic PeteGillinElastic approved these changes

Assignees

No one assigned

Labels

:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.19.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szybia @elasticsearchmachine @PeteGillinElastic