Add more transport version files validation #132373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases.
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
v9.1.2
v8.19.2
v8.18.6
and removed
v9.1.1
v8.19.1
v8.18.5
labels
JVerwolf
reviewed
Aug 11, 2025
| } | ||
| } | ||
|
|
||
| def javaSource(String project, String packageName, String className, String imports, String content) { |
There was a problem hiding this comment.
Nit: The purpose of this function is unobvious from the name. Some light javadoc or clearer name would help.
| } | ||
| } | ||
|
|
||
| def definedTransportVersion(String name, String ids) { |
There was a problem hiding this comment.
suggestion: addDefinedTransportVersion or defineTransportVersion. A "defined" TV is the result.
| "[myserver/src/main/resources/transport/defined/not_used.csv] is not referenced") | ||
| } | ||
|
|
||
| def "names must be lowercase"() { |
There was a problem hiding this comment.
Should we test that a few additional invalid names fail? (e.g. "hyphen-tv", "period.tv", "spaces tv", "trailing_spaces_tv ", "slashes/tv"). Should we also test that valid tvs succeed? (e.g. "valid", "valid_tv", "valid1", "valid_tv1"?). We could use a where: clause with a "data table" for this
| return results; | ||
| } | ||
|
|
||
| private static TransportVersionId parseId(String rawId) { |
There was a problem hiding this comment.
Should this be a static factory on TransportVersionId? e.g. fromString?
| return stdout.toString(StandardCharsets.UTF_8); | ||
| } | ||
|
|
||
| private void recordExistingResources() { |
There was a problem hiding this comment.
Is there a reason we use mutation here rather than having this function return the value that is used to initialize existingResources?
...ava/org/elasticsearch/gradle/internal/transport/ValidateTransportVersionDefinitionsTask.java
Show resolved
Hide resolved
JVerwolf
reviewed
Aug 11, 2025
...ava/org/elasticsearch/gradle/internal/transport/ValidateTransportVersionDefinitionsTask.java
Show resolved
Hide resolved
breskeby
reviewed
Aug 11, 2025
|
|
||
| @Inject | ||
| public ValidateTransportVersionDefinitionsTask(Project project, ExecOperations execOperations) { | ||
| this.project = project; |
There was a problem hiding this comment.
you can just use getProject() to reference the project object within a task
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 12, 2025
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases. Co-authored-by: Jack Conradson <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 12, 2025
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases. Co-authored-by: Jack Conradson <[email protected]>
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 12, 2025
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases. Co-authored-by: Jack Conradson <[email protected]>
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 12, 2025
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases. Co-authored-by: Jack Conradson <[email protected]>
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 12, 2025
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases. Co-authored-by: Jack Conradson <[email protected]>
rjernst
added a commit
that referenced
this pull request
Aug 13, 2025
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases. Co-authored-by: Jack Conradson <[email protected]>
rjernst
added a commit
that referenced
this pull request
Aug 13, 2025
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases. Co-authored-by: Jack Conradson <[email protected]>
rjernst
added a commit
that referenced
this pull request
Aug 13, 2025
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases. Co-authored-by: Jack Conradson <[email protected]>
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 15, 2025
* upstream/8.19: (62 commits) Use consistent terminology for transport version resources/references (elastic#132882) (elastic#132898) Move inner records out of TransportVersionUtils (elastic#132872) (elastic#132886) Forward port release notes for v8.18.5 (elastic#132758) Add more transport version files validation (elastic#132373) (elastic#132777) Forward port release notes for v8.17.10 (elastic#132760) Refactor TransportVersion loading to support external consumers (elastic#132694) (elastic#132862) manual backporting| (elastic#132783) 9.1 docs backports for 8.19 features (elastic#132605) Migrate x-pack-deprecation REST tests (elastic#131444) (elastic#132802) Update 8.19.1.asciidoc (elastic#132755) Update wolfi (versioned) (elastic#132752) Update 8.19.0.asciidoc (elastic#132754) Prune changelogs after 8.19.2 release Bump versions after 8.19.2 release Finalize release notes for v8.19.2 Bump versions after 8.17.10 release Prune changelogs after 8.18.5 release Bump versions after 8.18.5 release Add release notes for v8.19.2 release (elastic#132696) [ML] Improve EIS auth call logs and fix revocation bug (elastic#132546) (elastic#132690) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds additional validation cases to the new transport version resource files. It also adds gradle tests for the validation cases.
Jira: https://elasticco.atlassian.net/browse/ES-12336