-
Notifications
You must be signed in to change notification settings - Fork 25.6k
DiskBBQ - Adapt visited_ratio based on query - segment affinity in multi segment scenario #132396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
6c508e3
DiskBBQ - adjust query greediness based on per segment affinity
tteofili 6281bcf
wip fixes
tteofili 62e4d0c
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili ab11958
wip fixes
tteofili 980940e
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili 3f4e5fd
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili df0210d
Include top 2 parent scores into affinity, with larger segments
tteofili 8cbad8f
minor fix
tteofili b097c20
include (parent) centroids scores for affinity, with larger segments
tteofili 9499be1
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili 0635453
more sensible and generic threshold definition
tteofili d52dc40
[CI] Auto commit changes from spotless
c658856
Merge branch 'diskbbq_segment_affinity' of github.com:tteofili/elasti…
tteofili 34cf456
spotless
tteofili 0dc22eb
minor tweaks
tteofili 028482e
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili a6702eb
minor tweaks
tteofili 5288b8e
[CI] Auto commit changes from spotless
0a74a0c
set visited vector max budget ratio
tteofili 7600d50
Merge branch 'diskbbq_segment_affinity' of github.com:tteofili/elasti…
tteofili c3cec18
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili 4f98473
minor
tteofili 72d6d24
minor tweaks
tteofili 9ee4bfd
minor
tteofili 4f9982e
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili aeee542
minor tweaks, add knn tester param
tteofili 5facc1b
[CI] Auto commit changes from spotless
feedbdf
minor tweaks
tteofili 58a397b
Merge branch 'diskbbq_segment_affinity' of github.com:tteofili/elasti…
tteofili c3f97c9
minor tweaks
tteofili 363d987
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili 1b42ca3
spotless
tteofili dfd9ba2
Update docs/changelog/132396.yaml
tteofili b5446a2
Merge branch 'main' into diskbbq_segment_affinity
john-wagster e38e513
Merge branch 'main' into fork/tteofili/diskbbq_segment_affinity
iverase e3e2091
spotless
iverase ec987f7
Merge branch 'main' into diskbbq_segment_affinity
iverase 9337703
[DiskBBQ] Replace n_probe, related to the number of centroids with v…
iverase 71021f0
iter
iverase 651e359
doh
iverase 0d51546
iterate leaves to get total budget
john-wagster 36f0169
[CI] Auto commit changes from spotless
35dfb21
merging w ratio switchover, set default for ratio when creating strat…
john-wagster 08011c5
merging w head
john-wagster ebbbfd9
clean up refs to nprobe, fixing how we instatiate strategy and defaul…
john-wagster baa3ebb
improved counting docs and set a min budget
john-wagster c9daf27
spotless
john-wagster ffc9a64
Merge branch 'main' into visitRatio
iverase d0019c2
iter
iverase 528367a
Merge branch 'main' into visitRatio
iverase ab36139
Compute visitRatio globally when doing it dynamically
iverase b8b8091
Merge branch 'visitRatio' of github.com:iverase/elasticsearch into vi…
iverase 5a7f5d8
merging w latest ratioVisit, fixed how we collect docs w vectors count
john-wagster cb1c444
spotless
john-wagster 3d2720a
need to validate if scorer is null
john-wagster 5b8443c
Merge branch 'main' into visitRatio
iverase 66e11f7
cleanup
john-wagster b2b8bfe
fixing some calcs
john-wagster da21795
make expected depend on numVectors
iverase c80dcfc
assert we only support Float queries
iverase 1583fa4
two fixes
benwtrent db1aa73
Merge branch 'visitRatio' of github.com:iverase/elasticsearch into vi…
benwtrent 3b6f21d
merging w latest ratioVisit, slight adjustment to low affinity explor…
john-wagster 15d92d5
merging main
john-wagster 8ae7787
remove unnecessary scaling and visitRatio default duplicate logic
john-wagster ff4916d
calculating affinities accounting for some of the wide variance seen
john-wagster f3afcd6
calculating affinities accounting for some of the wide variance seen
john-wagster 22ce362
don't add task with 0 budget, adjust thresholds for skewed affinities…
tteofili 480fc0d
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili e8dbdef
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili d631243
comment
tteofili d261f02
remove explicit budget as it conflicts with visitedRatio, normalized …
tteofili e9d4d82
don't use affinity calculation for filters
tteofili 3b291df
minor fix
tteofili 76c22b9
more sensible visited ratio adjustment
tteofili 7f2e954
removed useless interface
tteofili d887b88
Merge branch 'main' into diskbbq_segment_affinity
benwtrent e8e7d12
pull out magic nums, clean up, set hard cap on when to apply visit ra…
john-wagster a67fb67
Merge branch 'main' into diskbbq_segment_affinity
john-wagster daea67d
Merge branch 'main' of github.com:elastic/elasticsearch into diskbbq_…
tteofili 571534c
merge
tteofili 8e13a3a
[CI] Auto commit changes from spotless
3d1c6b6
account for numVectors for segment size variance being high, more dec…
tteofili daa8f40
work better with unbalanced segments, simplified
tteofili 59cae53
Merge branch 'diskbbq_segment_affinity' of github.com:tteofili/elasti…
tteofili b9a9e23
changelog
tteofili File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
pr: 132396 | ||
summary: DiskBBQ - Adapt `visitRatio` based on query - segment affinity in multi segment | ||
scenario | ||
area: Vector Search | ||
type: enhancement | ||
issues: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.