- 
                Notifications
    You must be signed in to change notification settings 
- Fork 25.6k
Semantic text - CCS POC - DO NOT MERGE #132411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
  
     Closed
                    Changes from 36 commits
      Commits
    
    
            Show all changes
          
          
            37 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      482aad8
              
                Added test and instrumentation
              
              
                Mikep86 43174f1
              
                Store original query in InterceptedQueryBuilderWrapper
              
              
                Mikep86 a922ed5
              
                Spotless
              
              
                Mikep86 d9f37b7
              
                Added SemanticCrossClusterSearchIT
              
              
                Mikep86 b94b41c
              
                test development
              
              
                Mikep86 ed58e78
              
                Allow cross-cluster search
              
              
                Mikep86 bc1ef89
              
                Fix test
              
              
                Mikep86 9a7d6f4
              
                Send pre-intercepted request to remote cluster
              
              
                Mikep86 4740f0c
              
                Added match query test
              
              
                Mikep86 83923c4
              
                Added stub classes for match query builder wrapper
              
              
                Mikep86 a132f5d
              
                Merge branch 'main' into semantic-text_ccs-discovery
              
              
                Mikep86 f00a520
              
                Fix build error
              
              
                Mikep86 87a1eaf
              
                Fixed entitlement policy
              
              
                Mikep86 38af314
              
                Add PIT integration test
              
              
                Mikep86 4935515
              
                Added CCS minimize round-trips to query rewrite context
              
              
                Mikep86 9c251dc
              
                Code cleanup
              
              
                Mikep86 1e5cb6f
              
                Spotless
              
              
                Mikep86 8db87ab
              
                Add model registry to semantic query builder
              
              
                Mikep86 0b8a1a9
              
                Remove unused code
              
              
                Mikep86 c55628c
              
                Added the map embeddings provider
              
              
                Mikep86 65b20bd
              
                Added the single embeddings provider
              
              
                Mikep86 a335f34
              
                Update semantic query builder to use embeddings providers
              
              
                Mikep86 071f6c5
              
                Added TODOs
              
              
                Mikep86 0b945d4
              
                Make ccsMinimizeRoundtrips nullable
              
              
                Mikep86 33d1be1
              
                Fix build errors
              
              
                Mikep86 42d5eab
              
                Fix test errors
              
              
                Mikep86 43dda15
              
                Check that model registry is set
              
              
                Mikep86 cd878bd
              
                Allow CCS only when ccs_minimize_roundtrips=true
              
              
                Mikep86 d3937c1
              
                Perform inference on remote cluster when necessary
              
              
                Mikep86 659a79f
              
                Update integration test to use different inference IDs across clusters
              
              
                Mikep86 b407a4f
              
                Set model registry for each semantic query builder instance
              
              
                Mikep86 10ec96d
              
                Revert CrossClusterSearchIT changes
              
              
                Mikep86 7e2d973
              
                Revert InterceptedQueryBuilderWrapper changes
              
              
                Mikep86 c39adbe
              
                Revert MatchQueryBuilder changes
              
              
                Mikep86 9c58c11
              
                Adjust PIT test
              
              
                Mikep86 4fb6f42
              
                Remove match query test
              
              
                Mikep86 39b56cf
              
                Merge branch 'main' into semantic-text_ccs-discovery
              
              
                Mikep86 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -836,6 +836,7 @@ public QueryRewriteContext newQueryRewriteContext( | |
| null, | ||
| null, | ||
| null, | ||
| null, | ||
| false | ||
| ); | ||
| } | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -275,6 +275,7 @@ private SearchExecutionContext( | |
| null, | ||
| null, | ||
| null, | ||
| null, | ||
| false | ||
| ); | ||
| this.shardId = shardId; | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there precedent for having CCS-specific knobs like this in generic search code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but there's a good case to be made why this is necessary. The CCS mode affects the query rewrite cycle, thus we need a way to know about it within that context. Info is passed to query rewrite via
QueryRewriteContext, thus this implementation.