Skip to content

ESQL: Add optimisation rule to allow unbounded sort before INLINESTATS #132417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

ESQL: Add optimisation rule to allow unbounded sort before INLINESTATS #132417

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
efbca9b
Add optimisation rule to pull OrderBy above InlineJoin
bpintea Aug 4, 2025
b470b00
Fix existing test, bump cap
bpintea Aug 5, 2025
0a3f611
Merge branch 'main' into enh/allow_sort_before_inlinejoin
bpintea Aug 5, 2025
e9f1770
Update docs/changelog/132417.yaml
bpintea Aug 11, 2025
6a595c0
Merge branch 'main' into enh/allow_sort_before_inlinejoin
bpintea Aug 12, 2025
8c7b039
Merge branch 'main' into enh/allow_sort_before_inlinejoin
bpintea Aug 12, 2025
39fc575
review
bpintea Aug 18, 2025
849f621
Merge branch 'main' into enh/allow_sort_before_inlinejoin
bpintea Aug 18, 2025
64f0b7f
auto-merge artefact
bpintea Aug 18, 2025
a0fb3d3
Refactor to use forEachDownMayReturnEarly()
bpintea Aug 18, 2025
ddeeeba
finally, update javadoc
bpintea Aug 18, 2025
24e055c
compact code
bpintea Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/132417.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 132417
summary: Add optimisation rule to allow unbounded sort before INLINESTATS
area: ES|QL
type: enhancement
issues: []
4 changes: 2 additions & 2 deletions ...i-clusters/src/javaRestTest/java/org/elasticsearch/xpack/esql/ccq/MultiClusterSpecIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.ENABLE_LOOKUP_JOIN_ON_REMOTE;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.FORK_V9;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.INLINESTATS;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.INLINESTATS_V9;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.INLINESTATS_V10;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_LOOKUP_V12;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_PLANNING_V1;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.METADATA_FIELDS_REMOTE_TEST;
Expand Down Expand Up @@ -135,7 +135,7 @@ protected void shouldSkipTest(String testName) throws IOException {
assumeTrue("Test " + testName + " is skipped on " + oldVersion, isEnabled(testName, instructions, oldVersion));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS.capabilityName()));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(JOIN_PLANNING_V1.capabilityName()));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V9.capabilityName()));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V10.capabilityName()));
if (testCase.requiredCapabilities.contains(JOIN_LOOKUP_V12.capabilityName())) {
assumeTrue(
"LOOKUP JOIN not yet supported in CCS",
Expand Down
Loading