Skip to content

Conversation

@prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Aug 5, 2025

CompressorFactory.compressor was over-eager in detecting XContent type even when the type was already known.

  1. Refactor out a non-detecting version of the CompressorFactory.compress method
  2. Add a failing unit test for NotXContentException on invalid xcontent should not cause 500 errors #131605
  3. Fix the bug

Fixes #131605.

Reinstates #131655.

@prdoyle prdoyle self-assigned this Aug 5, 2025
@prdoyle prdoyle added >non-issue :Core/Infra/Core Core issues without another label labels Aug 5, 2025
@prdoyle prdoyle requested a review from a team as a code owner August 5, 2025 14:01
@prdoyle prdoyle added auto-backport Automatically create backport pull requests when merged v9.2.0 v8.19.1 labels Aug 5, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Aug 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (based on prior review).

@prdoyle prdoyle enabled auto-merge (squash) August 5, 2025 14:04
@prdoyle prdoyle disabled auto-merge August 5, 2025 14:04
@prdoyle prdoyle enabled auto-merge (squash) August 5, 2025 14:05
@prdoyle prdoyle merged commit 89ad24f into main Aug 5, 2025
33 of 34 checks passed
@prdoyle prdoyle deleted the revert-131866-revert-131655-fix-compressor branch August 5, 2025 15:03
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Aug 5, 2025
elasticsearchmachine pushed a commit that referenced this pull request Aug 5, 2025
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 6, 2025
…cking

* upstream/main: (24 commits)
  Revert "[Fleet] add privileges to `kibana_system` to read integrations data (elastic#132400)" (elastic#132499)
  ESQL: Rename evaluators for FIRST and LAST (elastic#132466)
  Add inference fields to semantic text docs (elastic#132471)
  ESQL: Allow FIRST and LAST as method name (elastic#132469)
  ESQL: Add javadoc for PushDownAndCombineFilters (elastic#132484)
  Misc cleanups in Coordinator (elastic#132452)
  [DiskBBQ] Write the maximum posting list size to avoid resizing the docId array (elastic#132447)
  Improve exception handling for JsonXContentParser (elastic#123439)
  Clarify quantization on semantic_text BBQ dense vector default (elastic#132470)
  Fix test infra NPE in doEnsureClusterStateConsistency (elastic#131859)
  Stabilize CancellableTasksIT#testRemoveBanParentsOnDisconnect (elastic#131858)
  Move ClusterApplierService assertion after logging exception (elastic#132446)
  ESQL: Support for multi-argument aggs (elastic#132424)
  Update wolfi (versioned) (elastic#132457)
  ESQL: Fix Function javadoc (elastic#132399)
  [ML] Inference API disable partial search results (elastic#132362)
  Unmute testTermsQuery tests (elastic#132409)
  Fix index lookup when field-caps returns empty mapping (elastic#132138)
  CompressorFactory.compressor (elastic#132448)
  ESQL add formatting to plans in javadoc (elastic#132421)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.19.1 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NotXContentException on invalid xcontent should not cause 500 errors

3 participants