-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add streaming response to ESQL #132453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ivancea
wants to merge
24
commits into
elastic:main
Choose a base branch
from
ivancea:esql-stream-response
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add streaming response to ESQL #132453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @ivancea, I've created a changelog YAML for you. |
Hi @ivancea, I've created a changelog YAML for you. |
…, and scaffold text stream
This reverts commit 5bc5e70.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
>enhancement
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
v9.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
// Spacetime project
The ESQL engine allows streaming already, but we just store the data and send it all at once. The idea is sending the data in 3 chunks instead:
Potential problems
page_size
pragma helps here, as long as there aren't commands that hold the full input (STATS, SORT...)In this PR
I'm separating the serialization (XContent) of every media type into a different class, and choosing the correct one in the RestAction:
EsqlQueryResponseStream
: Interface, to be called by the esql/compute engine codeAbstractEsqlQueryResponseStream
: Base class for most of the implementationsXContentEsqlQueryResponseStream
: The base class that sends XContent responsesTextEsqlQueryResponseStream
: For all the text formatsArrowEsqlQueryResponseStream
: Not implemented yetNonStreamingEsqlQueryResponseStream
: A class that will be used when the config is deactivated. Just a dummy, to avoid having to keep the old code around there, and make everything go through thisTo be done
OutputOperator
callback (ComputeService)Use cases