ESQL: Small fixes for COPY_SIGN #132459
Merged
ESQL: Small fixes for COPY_SIGN #132459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds some small fixes to `COPY_SIGN` and some docs and tests. The fixes are mostly supporting the literal `NULL` in parameters. `COPY_SIGN` supports `float` arguments, but the tests don't cover it because we don't build `float` blocks. Otherwise, the tests are fairly standard.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
Hi @nik9000, I've created a changelog YAML for you. |
nik9000
added
the
auto-backport
ivancea
approved these changes
Aug 6, 2025
| throw new IllegalArgumentException("bogus numeric type [" + type + "]"); | ||
| } | ||
|
|
||
| public static List<TypedDataSupplier> getSuppliersForNumericType(DataType type) { |
There was a problem hiding this comment.
Should we just call this getSuppliersForType() and implement for everything? (Or leave it with an exception for unhandled cases until we need them)
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 6, 2025
Adds some small fixes to `COPY_SIGN` and some docs and tests. The fixes are mostly supporting the literal `NULL` in parameters. `COPY_SIGN` supports `float` arguments, but the tests don't cover it because we don't build `float` blocks. Otherwise, the tests are fairly standard.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 6, 2025
Adds some small fixes to `COPY_SIGN` and some docs and tests. The fixes are mostly supporting the literal `NULL` in parameters. `COPY_SIGN` supports `float` arguments, but the tests don't cover it because we don't build `float` blocks. Otherwise, the tests are fairly standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some small fixes to
COPY_SIGNand some docs and tests. The fixes are mostly supporting the literalNULLin parameters.COPY_SIGNsupportsfloatarguments, but the tests don't cover it because we don't buildfloatblocks. Otherwise, the tests are fairly standard.