Skip to content

Conversation

@felixbarny
Copy link
Member

Before this change, IndexRouting wasn't able to fully take advantage of optimizedText. That's because it is using a non default XContentParserConfiguration (withFiltering), which creates a wrapper (FilteringParserDelegate). This prevented the parser to access the ESUTF8StreamJsonParser.

@felixbarny felixbarny requested a review from a team as a code owner August 5, 2025 16:14
@felixbarny felixbarny added >non-issue :Core/Infra/Core Core issues without another label :StorageEngine/Mapping The storage related side of mappings labels Aug 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine added v9.2.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@jordan-powers jordan-powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@jordan-powers
Copy link
Contributor

@elasticmachine test this please

@jordan-powers
Copy link
Contributor

Oops sorry, just realized CI had already run. I saw the external-contributor label and assumed it hadn't so I kicked off another build

@felixbarny felixbarny merged commit 54d3fd5 into elastic:main Aug 8, 2025
33 checks passed
@felixbarny felixbarny deleted the optimized-text-wrapper-aware branch August 8, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :StorageEngine/Mapping The storage related side of mappings Team:Core/Infra Meta label for core/infra team Team:StorageEngine v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants