Skip to content

ESQL: Allow FIRST and LAST as method name #132469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2025
Merged

ESQL: Allow FIRST and LAST as method name #132469

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0d07d1
ESQL: Allow FIRST and LAST as method name
nik9000 Aug 5, 2025
a0087a3
[CI] Auto commit changes from spotless
Aug 5, 2025
342863e
Merge branch 'main' into allow_function_named_first
nik9000 Aug 5, 2025
71a6749
Move it
nik9000 Aug 6, 2025
8142894
Merge remote-tracking branch 'nik9000/allow_function_named_first' int…
nik9000 Aug 6, 2025
7a4020d
Why'd you go?
nik9000 Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x-pack/plugin/esql/src/main/antlr/EsqlBaseParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ qualifiedNamePatterns
identifier
: UNQUOTED_IDENTIFIER
| QUOTED_IDENTIFIER
| FIRST
| LAST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth restricting FIRST/LAST to only a function name opposed to any identifier? Although somebody might want to use | EVAL first=first(column, @timestamp). Not sure.

;

identifierPattern
Expand Down
Loading