-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add cache miss and read metrics #132497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache miss and read metrics #132497
Conversation
Fix up the reads metric to also consider tryRead accessing a new region as a read/hit. Add cache miss metric that only increments once per region per read. Add a miss ratio as well for easy querying.
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Hi @henningandersen, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Henning
Thanks both! |
Fix up the reads metric to also consider tryRead accessing a new region as a read/hit. Add cache miss metric that only increments once per region per read. Add a miss ratio as well for easy querying.