ESQL: Add sub-logger just for changes from rules #132508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugging the analyzer and optimizers is easier when we focus only on the changes they make to the query plan. Let's add a separate sub-logger to RuleExecutor so we can selectively enable only logging of those changes.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Aug 6, 2025
| * } | ||
| * }</pre> | ||
| */ | ||
| private final Logger changeLog = LogManager.getLogger(getClass().getName() + ".changes"); |
There was a problem hiding this comment.
You tested this locally, right? I'm pretty sure this is right, but I can't write code without some kind of mistake.
There was a problem hiding this comment.
++ confirmed locally that
a) this does not accidentally exclude the changes in query plans when turning trace logging on for logger.org.elasticsearch.xpack.esql, and
b) you can, indeed, enable the changes logger for each individual optimizer/analyzer, separately, using the instructions from the javadoc.
Ideally, we'd have a test for this, but I don't know that we already test the trace logs anywhere; setting up tests for this small change might be a bit high effort compared to the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging the analyzer and optimizers is easier when we focus only on the changes they make to the query plan. Let's add a separate sub-logger to RuleExecutor so we can selectively enable only logging of those changes.
Based on a nice suggestion by @nik9000 . Thanks, Nik!