ESQL: Ungrouped agg implementations for FIRST/LAST #132513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually a few things: 1. Add generation for ungroups FIRST/LAST 2. Change the description of FIRST/LAST to be more readable 3. Allow that description to be specified instead of generated 4. Add grouped and ungrouped tests for FIRST/LAST 5. Grouped tests weren't passing with `null` groups. Always enabled group id tracking to fix it. 6. Reworked how grouped aggs trigger group id tracking for all grouped aggs to make them a little more consistent. Relates to elastic#108385
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
reviewed
Aug 6, 2025
| { | ||
| var properties = [:] | ||
| v1.forEach { k, v -> properties["v1_" + k] = v} | ||
| v2.forEach { k, v -> properties["v2_" + k] = v} |
There was a problem hiding this comment.
I do not understand above. Would we have only a single v1 and v2 here?
There was a problem hiding this comment.
I'll add a comment. we only need LongDouble, LongInt, LongLong, and LongFloat for the implementations we have now. I can drop LongBool - at least until we add more users.
dnhatn
approved these changes
Aug 7, 2025
| import java.util.Set; | ||
| import java.util.stream.IntStream; | ||
|
|
||
| public class FirstLongByTimestampGroupingAggregatorFunctionTests extends GroupingAggregatorFunctionTestCase { |
There was a problem hiding this comment.
Thank you for adding these tests :)
There was a problem hiding this comment.
It found a bug! A bug that doesn't exist in TSDB, so it can't matter to anyone using it so far!
… esql_first_ungrouped_impl
|
Thanks for the reviews friends! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually a few things:
nullgroups. Always enabled group id tracking to fix it.Relates to #108385