Adjust knn query cancellation checks to use collector pattern #132515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
commented
Aug 6, 2025
Comment on lines
+259
to
+260
| while (centroidIterator.hasNext() | ||
| && (centroidsVisited < nProbe || knnCollector.minCompetitiveSimilarity() == Float.NEGATIVE_INFINITY)) { |
There was a problem hiding this comment.
We were making a bad assumption before, assuming things were an AbstractKnnCollector. Instead, we should use the appropriate measure, which is Has the collector set a minCompetitiveSimilarity indicating it gathered enough vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in an effort to simplify and keep from unnecessarily wrapping the bits (which, when
nullcan have optimized internal paths for knn searches), this moves our cancellation checks to a knn collector.Additionally, it makes more sense for our cancellation checks to be done on collection.