Extract UpdateSnapshotStatusAction to its own file #132522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull a Transport*Action out of SnapshotsService in order to simplify and focus the SnapshotsService code. Relates ES-11650
DiannaHohensee
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
server/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
DiannaHohensee
commented
Aug 7, 2025
There was a problem hiding this comment.
Looks like SnapshotResiliencyTests just needs the new action added to the actions map in the TestClusterNode constructor.
Thanks for taking a look at the test failure, fixed in 46bb887
server/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
elasticsearchmachine
added
the
serverless-linked
DiannaHohensee
added
auto-merge-without-approval
|
Found a stateless action caller: put up https://github.com/elastic/elasticsearch-serverless/pull/4352 to update that caller. |
DiannaHohensee
added
serverless-linked
ywangd
reviewed
Aug 8, 2025
| actions.register(TransportDeleteSnapshotAction.TYPE, TransportDeleteSnapshotAction.class); | ||
| actions.register(TransportCreateSnapshotAction.TYPE, TransportCreateSnapshotAction.class); | ||
| actions.register(TransportCloneSnapshotAction.TYPE, TransportCloneSnapshotAction.class); | ||
| actions.register(TransportUpdateSnapshotStatusAction.TYPE, TransportUpdateSnapshotStatusAction.class); |
There was a problem hiding this comment.
This is no need to register this action here since it is never invoked by Client. We will not need modify the operator privilege Constants if we don't register the action here.
ywangd
reviewed
Aug 8, 2025
Comment on lines
+2513
to
+2516
| actions.put( | ||
| TransportUpdateSnapshotStatusAction.TYPE, | ||
| new TransportUpdateSnapshotStatusAction(transportService, clusterService, threadPool, snapshotsService, actionFilters) | ||
| ); |
There was a problem hiding this comment.
Similary, there should be no need to add it to actions. Simply instantiate it should be sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull a Transport*Action out of SnapshotsService
in order to simplify and focus the SnapshotsService
code.
Relates ES-11650
A step of the refactor plan described in #127419