Add index setting to control whether fields are indexed by default. #132525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>non-issue
:StorageEngine/Mapping
martijnvg
commented
Aug 7, 2025
| DateFieldMapper dateFieldMapper = (DateFieldMapper) mapper; | ||
| if (dateFieldMapper.fieldType().isIndexed() == false && dateFieldMapper.fieldType().hasDocValuesSkipper() == false) { | ||
| throw new IllegalArgumentException("data stream timestamp field [" + DEFAULT_PATH + "] is not indexed"); | ||
| if (dateFieldMapper.fieldType().isSearchable() == false) { |
There was a problem hiding this comment.
This should be done in a separate change.
Introduce `index.mapping.index_disabled_by_default` index setting to control the default of `index` mapping attribute of all field types except for `text` and `match_only_text` (doesn't have `index` attribute). Default to `false`, which means all field types are indexed by default. But it can be configured to change the default of the `index` mapping attribute. Note that if `index` is configured on a field that always takes precedence. This change just allows changing the default for mentioned field types with one simple setting change.
martijnvg
force-pushed
the
index_disabled_by_default
branch
from
2d8ea8f to
43008cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
index.mapping.index_disabled_by_defaultindex setting to control the default ofindexmapping attribute of all field types except fortext,match_only_text(doesn't have anindexattribute). Additionally this index settings doesn't change whether meta field (e.g._id) are indexed.Default to
false, which means all field types are indexed by default. But it can be configured to change the default of theindexmapping attribute.Note that if
indexis configured on a field that always takes precedence. This change just allows changing the default for mentioned field types with one simple setting change.Initially this new index setting will be helpful experimenting with what indexing performance is with close to zero indexed data structures. However it could also be useful to configurations of Elasticsearch that with minimal indexing overhead at the expense of higher query latencies.
The index setting is currently gated behind a feature flag.