Skip to content

Add ESQL DAY_NAME function #132535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 8, 2025
Merged

Add ESQL DAY_NAME function #132535

merged 13 commits into from
Aug 8, 2025

Conversation

romulets
Copy link
Member

@romulets romulets commented Aug 7, 2025 •
edited
Loading

Relates to #98545

Introduces DAY_NAME function, similar to MySQL behaviour.

Given a date or date_nanos return the weekday name for the specified day based on the configured Locale

@elasticsearchmachine elasticsearchmachine added v9.2.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 7, 2025
@nik9000 nik9000 added >feature :Analytics/ES|QL AKA ESQL and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025 •
edited
Loading

🔍 Preview links for changed docs

@romulets romulets changed the title Add DayName function Add ESQL DAY_NAME function Aug 7, 2025
@romulets romulets requested a review from nik9000 August 7, 2025 14:11
@romulets romulets marked this pull request as ready for review August 7, 2025 14:11
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@romulets romulets mentioned this pull request Jun 9, 2025
Open
nik9000
nik9000 requested changes Aug 7, 2025
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You need to make a change to the docs generation and rerun the test for it to slurp the docs change into the generated docs. But otherwise I think it's read.

@nik9000
Copy link
Member

nik9000 commented Aug 7, 2025

Looks good to me. You need to make a change to the docs generation and rerun the test for it to slurp the docs change into the generated docs. But otherwise I think it's read.

ready

romulets
romulets commented Aug 8, 2025
View reviewed changes
Copy link
Member Author

@romulets romulets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied Changes @nik9000

@romulets romulets requested a review from nik9000 August 8, 2025 04:34
@romulets romulets enabled auto-merge (squash) August 8, 2025 14:34
@romulets romulets merged commit f7a9fe6 into elastic:main Aug 8, 2025
33 checks passed
@alex-spies alex-spies mentioned this pull request Aug 11, 2025
Closed
alex-spies added a commit that referenced this pull request Aug 12, 2025
@alex-spies
ESQL: Update num released functions after #132535 (#132673)
cd9f620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL >feature Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romulets @elasticsearchmachine @nik9000