Skip to content

Enable optimizedText for CBOR #132542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 8, 2025
Merged

Enable optimizedText for CBOR #132542

merged 13 commits into from
Aug 8, 2025

Conversation

felixbarny
Copy link
Member

No description provided.

@felixbarny felixbarny requested a review from a team as a code owner August 7, 2025 15:58
@felixbarny felixbarny added :Core/Infra/Core Core issues without another label :StorageEngine/Mapping The storage related side of mappings labels Aug 7, 2025
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:StorageEngine v9.2.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

jordan-powers
jordan-powers reviewed Aug 7, 2025
View reviewed changes
Copy link
Contributor

@jordan-powers jordan-powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outline looks good, but I think there are a couple of bugs related to the parser state. We want to avoid disrupting the parser so that it still works as normal even after calling getValueAsText().

@felixbarny
More efficient implementation of Text#stringLength
2044512 
Doesn't need to decode, just counts the number of characters while iterating over the utf8-encoded bytes.
@felixbarny
Fix state handling in ESCborParser
c76226e
@felixbarny
Copy link
Member Author

Good catch, thanks!

@felixbarny felixbarny requested a review from a team as a code owner August 8, 2025 09:56
@felixbarny felixbarny mentioned this pull request Aug 8, 2025
Merged
jordan-powers
jordan-powers approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@jordan-powers jordan-powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Felix!

@jordan-powers jordan-powers mentioned this pull request Jul 10, 2025
Open
7 tasks
@felixbarny felixbarny enabled auto-merge (squash) August 8, 2025 19:34
@felixbarny felixbarny merged commit 8e0ac6d into elastic:main Aug 8, 2025
33 checks passed
@felixbarny felixbarny deleted the cbor-optimized-text branch August 8, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordan-powers jordan-powers jordan-powers approved these changes

@martijnvg martijnvg Awaiting requested review from martijnvg

Assignees

@felixbarny felixbarny

Labels

:Core/Infra/Core Core issues without another label external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :StorageEngine/Mapping The storage related side of mappings Team:Core/Infra Meta label for core/infra team Team:StorageEngine v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixbarny @elasticsearchmachine @jordan-powers @martijnvg