-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Add epoch blob-cache metric #132547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add epoch blob-cache metric #132547
Conversation
Add epoch (changes) as a metric to the blob-cache, giving visibility into the velocity of change in the cache and indications of cache churn
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
|
Hi @henningandersen, I've created a changelog YAML for you. |
tlrx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andreidan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this Henning.
The change itself LGTM but I'm not entirely sure what this metric will give us?
i.e. a steadily increasing epoch will point to our decaying task running as expected ?
I could perhaps see the metric being interesting if we are to correlate it with an entry's lastAccessedEpoch but I'm not exactly following why is this metric useful in isolation?
|
We discussed this and clarified that it is the rate of change that is interesting, in particular for comparing across different clusters, a high rate could seem to be an indication of cache undersize or problem relative to a low rate. |
|
Thanks both! |
Add epoch (changes) as a metric to the blob-cache, giving visibility into the velocity of change in the cache and indications of cache churn
Relates ES-12595