Rename some transport actions to be more consistent with others

[samxbr]

Rename a bunch of transport actions from XXXTransportAction to TransportXXXAction so they are more consistent with the rest of the transport actions.

[rjernst]

This seems the wrong direction to me. XXXTransportAction is more canonical in my mind, and parallels how rest actions (should be) named, as XXXRestAction (or XXXRestHandler, but there's a whole other set of naming inconsistencies there to consider).

[samxbr]

This seems the wrong direction to me. XXXTransportAction is more canonical in my mind, and parallels how rest actions (should be) named, as XXXRestAction (or XXXRestHandler, but there's a whole other set of naming inconsistencies there to consider).

Naming is always the hard topic... To me it seems TransportXXXAction and RestXXXAction are used more widely than the other way. I think I have seem TransportXXXAction/RestXXXAction more frequently than XXXTransportAction/XXXRestAction, which made me thought they are accepted more widely, but I could be wrong on this. The intention is to make these names a little bit more standardized across, it always bugs me that I need to try different names when searching these actions.

(Personally I feel it is a tiny bit more readable to see the keyword Transport/Rest at the front)

[elasticsearchmachine]

Pinging @elastic/es-core-infra (Team:Core/Infra)

[samxbr]

There are some more transport actions with inconsistent name but I am going to stop here and put this out to get some opinion first.

[samxbr]

There are different options on this naming convention:

1. leave it the way it is (mixed XXXTransportAction and TransportXXXAction)
2. choose a naming convention and consolidate them (XXXTransportAction vs TransportXXXAction, or maybe other options)

I'd like to do 2) and personally I am in favor of TransportXXXAction. @rjernst Since you express interest, do you think this needs more discussion, or maybe with more audience?

[rjernst]

I think it will need some discussion. Github comments probably aren't the right place for that discussion.

[samxbr]

Closing this PR for now after discussion with @rjernst. There's more discussion needed and a decision needs to be made within Core Infra. Opened an issue instead.