Enable RemoteClusterService client features on search nodes by default for CPS
#132553
Conversation
For CPS in serverless we do not want to support RemoteClusterService client features on non-search nodes. This PR checks if stateless is enabled, and if so requires the node to have the search role to use RemoteClusterService client features. If stateless is disabled the check is only for the remote cluster client role, as is currently done today. Resolves: ES-12597.
JeremyDahlgren
added
>non-issue
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
One minor comment. Also, you need to update the usage in TransportGetProjectTagsAction on the stateless side to avoid breaking serverless build.
server/src/test/java/org/elasticsearch/transport/RemoteClusterServiceTests.java
Outdated
Show resolved
Hide resolved
|
On the tech design doc, IIUC, Henning suggested enabling remote cluster client by default for search nodes. Is this something we want to have? If so, is it going to be a separate PR? |
elasticsearchmachine
added
the
serverless-linked
Yes, you are correct, I needed to adjust the logic in
I added linked PR 4355 to address this. |
JeremyDahlgren
changed the title
RemoteClusterService client features on non-search nodes for CPSRemoteClusterService client features on search nodes by default for CPS
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
LGTM
The new enforcement makes sense to me.
server/src/test/java/org/elasticsearch/transport/RemoteClusterServiceTests.java
Outdated
Show resolved
Hide resolved
3 participants
For CPS in serverless we do not want to support
RemoteClusterServiceclient features on non-search nodes that do not explicitly have the remote cluster client role set. This PR checks if stateless is enabled, and if so requires the node to have the search node role to useRemoteClusterServiceclient features if the remote cluster client role is not set. If stateless is disabled the check is only for the remote cluster client role, as is currently done today.Resolves: ES-12597.