Enable RemoteClusterService client features on search nodes by default for CPS
#132553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For CPS in serverless we do not want to support RemoteClusterService client features on non-search nodes. This PR checks if stateless is enabled, and if so requires the node to have the search role to use RemoteClusterService client features. If stateless is disabled the check is only for the remote cluster client role, as is currently done today. Resolves: ES-12597.
JeremyDahlgren
added
>non-issue
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
reviewed
Aug 8, 2025
server/src/test/java/org/elasticsearch/transport/RemoteClusterServiceTests.java
Outdated
Show resolved
Hide resolved
|
On the tech design doc, IIUC, Henning suggested enabling remote cluster client by default for search nodes. Is this something we want to have? If so, is it going to be a separate PR? |
elasticsearchmachine
added
the
serverless-linked
Yes, you are correct, I needed to adjust the logic in
I added linked PR 4355 to address this. |
JeremyDahlgren
changed the title
RemoteClusterService client features on non-search nodes for CPSRemoteClusterService client features on search nodes by default for CPS
ywangd
approved these changes
Aug 11, 2025
server/src/test/java/org/elasticsearch/transport/RemoteClusterServiceTests.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CPS in serverless we do not want to support
RemoteClusterServiceclient features on non-search nodes that do not explicitly have the remote cluster client role set. This PR checks if stateless is enabled, and if so requires the node to have the search node role to useRemoteClusterServiceclient features if the remote cluster client role is not set. If stateless is disabled the check is only for the remote cluster client role, as is currently done today.Resolves: ES-12597.