-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[logstash-bridge] Introduce GeoIp interfaces #132595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[logstash-bridge] Introduce GeoIp interfaces #132595
Conversation
bf88d27
to
65d9b9c
Compare
…ng elastic_integration integration tests.
…for multi-project.
…t upgrading the dependency, apply same to the logstash-bridge.
… pipeline execution.
…ingRunnable ES core components.
fea4f18
to
7eb593c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While there's a lot going on here, I'm pretty confident in the general shape and the downstream project is passing CI when pointed at these changes.
- all bridges are interfaces, and provide factory methods to create instances from bridged inputs, making the
ProxyInternal
-ish classes locked-down implementation details of this bridge that are not exposed to consumers of the bridge. - we provide
AbstractExternal
...Bridge
base classes for implementing bridged interfaces externally without needing to know about Elasticsearch-internal types.
exports org.elasticsearch.ingest.geoip.stats to org.elasticsearch.server; | ||
|
||
exports org.elasticsearch.ingest.geoip to com.maxmind.db; | ||
exports org.elasticsearch.ingest.geoip to com.maxmind.db, org.elasticsearch.logstashbridge; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can understand that this needs to export to org.elasticsearch.logstashbridge
, but am unsure why it needs to export to com.maxmind.db
, which I believe to be a dependency of this module (not dependent on this module).
I'm okay paring this off as a separate thing to chase down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Your assumption is correct and I believe we should remove this. I will do it now as I don't see any harmful side affects to our changes.
While we're tagged |
What this PR does?
It introduces GeoIP bridge interfaces where Logstash
elastic_integration
plugin can utilize.gradle check
?