Skip to content

Fix testLimitConcurrentNodes #132633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

idegtiarenko
Copy link
Contributor

The test is checking that we dispatch 5 requests 2 at the time, however some failures happened observing concurrency of 1.
This could rarely happen when request producer is slower than dispatcher. I was not able to reproduce this.
I think this is less likely to happen if we have more requests. Updating the test to send 10 requests instead of 5.

Closes: #132607

@idegtiarenko idegtiarenko requested review from nik9000 and dnhatn August 11, 2025 08:05
@idegtiarenko idegtiarenko added >test-failure Triaged test failures from CI Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v9.2.0 labels Aug 11, 2025
@elasticsearchmachine elasticsearchmachine added the needs:risk Requires assignment of a risk label (low, medium, blocker) label Aug 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@idegtiarenko idegtiarenko merged commit 6314a60 into elastic:main Aug 12, 2025
33 checks passed
@idegtiarenko idegtiarenko deleted the fix_testLimitConcurrentNodes branch August 12, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] DataNodeRequestSenderTests testLimitConcurrentNodes failing
3 participants