Skip to content

[8.19] Add TestEntitlementsRule with support for dynamic entitled node paths for testing (#132077) #132636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

mosche
Copy link
Contributor

@mosche mosche commented Aug 11, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

…hs for testing (elastic#132077)

Use TestEntitlementsRule and closable entitled node paths for better isolation and management of entitlement related state during tests.

However, wipePendingDataDirectories in tests requires entitlement delegation to work as this uses server's FileSystemUtils. Until ES-10920 is solved, entitled node paths cannot be removed unless the test suite completes or explicitly removing all entitled node paths in-between tests (if cluster scope is TEST).

Relates to ES-12042

(cherry picked from commit 76dac08)
@mosche mosche added >test Issues or PRs that are addressing/adding tests >refactoring auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Entitlements Entitlements infrastructure and removed v8.19.2 labels Aug 11, 2025
@elasticsearchmachine elasticsearchmachine merged commit 158d7f5 into elastic:8.19 Aug 11, 2025
23 checks passed
@mosche mosche deleted the backport/8.19/pr-132077 branch August 11, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Entitlements Entitlements infrastructure >refactoring >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants