Skip to content

Conversation

jaybcee
Copy link
Member

@jaybcee jaybcee commented Aug 11, 2025

In EIS, we've determined that the best batch size at the moment is of size 16, not 512. Updating the maximum batch size to reflect reality. We previously thought it would not necessarily need to be set.

Ref: https://github.com/elastic/search-team/issues/10719

@jaybcee jaybcee added auto-backport Automatically create backport pull requests when merged v9.0.0 v9.1.0 v8.19.0 v8.19.1 v8.19.2 labels Aug 11, 2025
Copy link
Contributor

@timgrein timgrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add maybe a comment with the context why we set it to 16? I see this could cause some confusion in the future why we went down from 512 to 16. Otherwise LGTM 🚢

@jaybcee jaybcee changed the title Update EIS sparse embedding max batch size to 16 Update EIS sparse and dense embedding max batch size to 16 Aug 11, 2025
@jaybcee jaybcee marked this pull request as ready for review August 11, 2025 14:24
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Aug 11, 2025
@jaybcee jaybcee added the Team:ML Meta label for the ML team label Aug 11, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:ML Meta label for the ML team label Aug 11, 2025
@prwhelan prwhelan added >non-issue :ml Machine learning Team:ML Meta label for the ML team labels Aug 11, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Aug 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@prwhelan prwhelan added >bug and removed >non-issue labels Aug 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @jaybcee, I've created a changelog YAML for you.

@jaybcee jaybcee enabled auto-merge (squash) August 11, 2025 14:37
@jaybcee jaybcee merged commit 81b4cce into main Aug 11, 2025
34 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0 Commit could not be cherrypicked due to conflicts
8.19 Commit could not be cherrypicked due to conflicts
9.1

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 132646

@jaybcee
Copy link
Member Author

jaybcee commented Aug 13, 2025

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

jaybcee added a commit that referenced this pull request Aug 27, 2025
…132855)

(cherry picked from commit 81b4cce)

# Conflicts:
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceService.java

Co-authored-by: Jonathan Buttner <[email protected]>
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 11, 2025
…32646) (elastic#132855)

(cherry picked from commit 81b4cce)

# Conflicts:
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceService.java

Co-authored-by: Jonathan Buttner <[email protected]>
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 19, 2025
…32646) (elastic#132855)

(cherry picked from commit 81b4cce)

# Conflicts:
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceService.java

Co-authored-by: Jonathan Buttner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >bug :ml Machine learning Team:ML Meta label for the ML team v8.19.0 v8.19.1 v8.19.2 v9.0.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants