-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ESQL load all dimensions when doing a Time Series query #132687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
not-napoleon
merged 25 commits into
elastic:main
from
not-napoleon:fieldcaps-dimension-filter
Aug 27, 2025
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e2c2a7c
add dimension filter to field caps
not-napoleon 4a38b0b
Merge branch 'main' into fieldcaps-dimension-filter
not-napoleon 33f975c
[CI] Auto commit changes from spotless
fb35040
add flag for collecting dimensions
not-napoleon 980a99a
plumb through the flag to fieldcaps
not-napoleon 0c11a2a
detect time series mode when resolving field names
not-napoleon 5ff350c
Merge remote-tracking branch 'refs/remotes/not-napoleon/fieldcaps-dim…
not-napoleon d65202f
[CI] Auto commit changes from spotless
74fa6a8
fix tests
not-napoleon a5c830b
Merge remote-tracking branch 'refs/remotes/not-napoleon/fieldcaps-dim…
not-napoleon d0dcf7c
[CI] Auto commit changes from spotless
f041e71
Merge branch 'main' into fieldcaps-dimension-filter
not-napoleon 5292071
missed a spot
not-napoleon 0c9014e
this test shouldn't be commented out
not-napoleon 083594d
Merge branch 'main' into fieldcaps-dimension-filter
not-napoleon 794b96c
Merge remote-tracking branch 'refs/remotes/not-napoleon/fieldcaps-dim…
not-napoleon a157a64
Merge branch 'main' into fieldcaps-dimension-filter
not-napoleon dc6c618
response to PR feedback
not-napoleon ada3b48
remove unnecessary changes to FieldNameUtils
not-napoleon 9e2946d
spelled the magic word wrong
not-napoleon 4bca905
Merge branch 'main' into fieldcaps-dimension-filter
not-napoleon da094a4
add appropriate capability check?
not-napoleon 2bcc34c
Merge remote-tracking branch 'refs/remotes/not-napoleon/fieldcaps-dim…
not-napoleon 3b5037f
revert changes to downsample.yml; Those were applied in a different PR
not-napoleon 1616c05
Merge branch 'main' into fieldcaps-dimension-filter
not-napoleon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
+dimensionsreads better to me?+dimensionimplies that there is only one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although having said that, we already have
+parentthat can return multiple parents, so maybe it's fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I had been following the "convention" from
+parent, but I don't feel strongly one way or the other.