ES|QL: Fix generative tests - exclude unsupported fields #132708
Conversation
luigidellaquila
added
>test
elasticsearchmachine
added
v9.2.0
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There was a problem hiding this comment.
Thank you @luigidellaquila !
I left an optional suggestion to limit the scope of the exclusion; please proceed at your own discretion :)
| // no dense vectors for now, they are not supported in most commands | ||
| || field.type().contains("vector")) == false; | ||
| || field.type().contains("vector") | ||
| || field.type().contains("unsupported")) == false; |
There was a problem hiding this comment.
Unsupported fields can be used in KEEP,DROP, RENAME and may pose interesting edge cases, esp. as they naturally occur with union types.
Since this is just about vector fields, maybe we can go and check the original type to exclude just unsupported fields with original type ..._vector?
There was a problem hiding this comment.
Good point, it will need a small refactoring in the generative tests (I'm not capturing original types now), but it should be feasible.
There was a problem hiding this comment.
Done.
@alex-spies if you have a chance, please have another quick look
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
Backporting manually #132791 |
3 participants
Exclude
vectorfields from generative tests.Fixes: #132520