Skip to content

Update MMapDirectory ReadAdvice function #132710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecoop merged 1 commit into from
Aug 12, 2025
Merged

Update MMapDirectory ReadAdvice function #132710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions server/src/main/java/org/elasticsearch/index/store/FsDirectoryFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import java.util.Optional;
import java.util.OptionalLong;
import java.util.Set;
import java.util.function.BiFunction;
import java.util.function.BiPredicate;

public class FsDirectoryFactory implements IndexStorePlugin.DirectoryFactory {
Expand Down Expand Up @@ -96,18 +97,11 @@ protected Directory newFSDirectory(Path location, LockFactory lockFactory, Index
}
}

private static Optional<ReadAdvice> overrideReadAdvice(String name, IOContext context) {
if (context.hints().contains(StandardIOBehaviorHint.INSTANCE)) {
return Optional.of(ReadAdvice.NORMAL);
}
return Optional.empty();
}

/** Sets the preload, if any, on the given directory based on the extensions. Returns the same directory instance. */
// visibility and extensibility for testing
public MMapDirectory setMMapFunctions(MMapDirectory mMapDirectory, Set<String> preLoadExtensions) {
mMapDirectory.setPreload(getPreloadFunc(preLoadExtensions));
mMapDirectory.setReadAdviceOverride(FsDirectoryFactory::overrideReadAdvice);
mMapDirectory.setReadAdvice(getReadAdviceFunc());
return mMapDirectory;
}

Expand All @@ -123,6 +117,15 @@ static BiPredicate<String, IOContext> getPreloadFunc(Set<String> preLoadExtensio
return MMapDirectory.NO_FILES;
}

private static BiFunction<String, IOContext, Optional<ReadAdvice>> getReadAdviceFunc() {
return (name, context) -> {
if (context.hints().contains(StandardIOBehaviorHint.INSTANCE)) {
return Optional.of(ReadAdvice.NORMAL);
}
return MMapDirectory.ADVISE_BY_CONTEXT.apply(name, context);
};
}

/**
* Returns true iff the directory is a hybrid fs directory
*/
Expand Down