Skip to content

Change reporting_user role to leverage reserved kibana privileges #132766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 18, 2025
+16 −25
Merged

Change reporting_user role to leverage reserved kibana privileges #132766

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
efecf69
Change reporting_user role to leverage reserved kibana privileges
legrego Aug 12, 2025
b443537
[CI] Auto commit changes from spotless
Aug 12, 2025
f8af0b4
Mark reporting_user role as deprecated
legrego Aug 12, 2025
52c0b3e
Merge branch 'fix-reporting_user-role' of github.com:legrego/elastics…
legrego Aug 12, 2025
76939f9
Update docs/changelog/132766.yaml
legrego Aug 18, 2025
dc0cf91
Update release notes
legrego Aug 18, 2025
427e47b
Merge branch 'main' into fix-reporting_user-role
legrego Aug 18, 2025
33d2e7f
Merge branch 'main' into fix-reporting_user-role
legrego Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions ...e/src/main/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,23 +328,13 @@ private static Map<String, RoleDescriptor> initializeReservedRoles() {
null,
new RoleDescriptor.ApplicationResourcePrivileges[] {
RoleDescriptor.ApplicationResourcePrivileges.builder()
.application("kibana-.kibana")
.application("kibana-*")
.resources("*")
.privileges(
"feature_discover.minimal_read",
"feature_discover.generate_report",
"feature_dashboard.minimal_read",
"feature_dashboard.generate_report",
"feature_dashboard.download_csv_report",
"feature_canvas.minimal_read",
"feature_canvas.generate_report",
"feature_visualize.minimal_read",
"feature_visualize.generate_report"
)
.privileges("reserved_reporting_user")
.build() },
null,
null,
MetadataUtils.DEFAULT_RESERVED_METADATA,
MetadataUtils.getDeprecatedReservedMetadata("Please grant access via Kibana privileges instead."),
null,
null,
null,
Expand All @@ -353,7 +343,7 @@ private static Map<String, RoleDescriptor> initializeReservedRoles() {
+ "including generating and downloading reports. "
+ "This role implicitly grants access to all Kibana reporting features, "
+ "with each user having access only to their own reports. Note that reporting users should also be assigned "
+ "additional roles that grant read access to the indices that will be used to generate reports."
+ "additional roles that grant read access to Kibana, and the indices that will be used to generate reports."
)
),
entry(KibanaSystemUser.ROLE_NAME, kibanaSystemRoleDescriptor(KibanaSystemUser.ROLE_NAME)),
Expand Down
13 changes: 2 additions & 11 deletions .../test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2769,20 +2769,11 @@ public void testReportingUserRole() {
RoleDescriptor roleDescriptor = ReservedRolesStore.roleDescriptor("reporting_user");
assertNotNull(roleDescriptor);
assertThat(roleDescriptor.getMetadata(), hasEntry("_reserved", true));
assertThat(roleDescriptor.getMetadata(), hasEntry("_deprecated", true));

final String applicationName = "kibana-.kibana";

final Set<String> applicationPrivilegeNames = Set.of(
"feature_discover.minimal_read",
"feature_discover.generate_report",
"feature_dashboard.minimal_read",
"feature_dashboard.generate_report",
"feature_dashboard.download_csv_report",
"feature_canvas.minimal_read",
"feature_canvas.generate_report",
"feature_visualize.minimal_read",
"feature_visualize.generate_report"
);
final Set<String> applicationPrivilegeNames = Set.of("reserved_reporting_user");

final Set<String> allowedApplicationActionPatterns = Set.of(
"login:",
Expand Down