Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/changelog/132766.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
pr: 132766
summary: Change `reporting_user` role to leverage reserved kibana privileges
area: Authorization
type: deprecation
issues: []
deprecation:
title: Change `reporting_user` role to leverage reserved kibana privileges
area: Authorization
details: Please describe the details of this change for the release notes. You can
use asciidoc.
impact: Please describe the impact of this change to users
Original file line number Diff line number Diff line change
Expand Up @@ -328,23 +328,13 @@ private static Map<String, RoleDescriptor> initializeReservedRoles() {
null,
new RoleDescriptor.ApplicationResourcePrivileges[] {
RoleDescriptor.ApplicationResourcePrivileges.builder()
.application("kibana-.kibana")
.application("kibana-*")
.resources("*")
.privileges(
"feature_discover.minimal_read",
"feature_discover.generate_report",
"feature_dashboard.minimal_read",
"feature_dashboard.generate_report",
"feature_dashboard.download_csv_report",
"feature_canvas.minimal_read",
"feature_canvas.generate_report",
"feature_visualize.minimal_read",
"feature_visualize.generate_report"
)
.privileges("reserved_reporting_user")
.build() },
null,
null,
MetadataUtils.DEFAULT_RESERVED_METADATA,
MetadataUtils.getDeprecatedReservedMetadata("Please grant access via Kibana privileges instead."),
null,
null,
null,
Expand All @@ -353,7 +343,7 @@ private static Map<String, RoleDescriptor> initializeReservedRoles() {
+ "including generating and downloading reports. "
+ "This role implicitly grants access to all Kibana reporting features, "
+ "with each user having access only to their own reports. Note that reporting users should also be assigned "
+ "additional roles that grant read access to the indices that will be used to generate reports."
+ "additional roles that grant read access to Kibana, and the indices that will be used to generate reports."
)
),
entry(KibanaSystemUser.ROLE_NAME, kibanaSystemRoleDescriptor(KibanaSystemUser.ROLE_NAME)),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2769,20 +2769,11 @@ public void testReportingUserRole() {
RoleDescriptor roleDescriptor = ReservedRolesStore.roleDescriptor("reporting_user");
assertNotNull(roleDescriptor);
assertThat(roleDescriptor.getMetadata(), hasEntry("_reserved", true));
assertThat(roleDescriptor.getMetadata(), hasEntry("_deprecated", true));

final String applicationName = "kibana-.kibana";

final Set<String> applicationPrivilegeNames = Set.of(
"feature_discover.minimal_read",
"feature_discover.generate_report",
"feature_dashboard.minimal_read",
"feature_dashboard.generate_report",
"feature_dashboard.download_csv_report",
"feature_canvas.minimal_read",
"feature_canvas.generate_report",
"feature_visualize.minimal_read",
"feature_visualize.generate_report"
);
final Set<String> applicationPrivilegeNames = Set.of("reserved_reporting_user");

final Set<String> allowedApplicationActionPatterns = Set.of(
"login:",
Expand Down