-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ES|QL] Rewrite RoundTo to QueryAndTags and merge range queries on RoundTo field #132781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fang-xing-esql
wants to merge
18
commits into
elastic:main
from
fang-xing-esql:pushdown-roundto-merge-range-query
Closed
[ES|QL] Rewrite RoundTo to QueryAndTags and merge range queries on RoundTo field #132781
fang-xing-esql
wants to merge
18
commits into
elastic:main
from
fang-xing-esql:pushdown-roundto-merge-range-query
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fang-xing-esql, I've created a changelog YAML for you. |
|
#132512 was merged, we don't do the merge range queries right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement on top of #132512 - merge the range query generated from the
RoundTofunction with the range query on the same field generated from predicates. The motivation is to measure if the performance is better when the range queries are merged when possible.#132512 generates a list of query with tags, and each query leg attaches a range query to the main query, if there are range query on the same field in the main query, the two range queries are separated, and not merged together.
It looks like below
This PR merges this two range queries above into one range query when applicable(one is superset of the other), the above query leg will look like below.
Here are some performance measurement on main, the branch without merging range queries, and this branch that merges range queries