[ML] Adding internal input types #132849
Merged
[ML] Adding internal input types #132849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
LGTM
The INTERNAL enums are very trappy. The reason they exist is to allow ingest and search operations in Elasticsearch that use the inference API to specify the intended use without having to know if the service supports the distinction between ingest and search.
Some services do not distinguish between ingest and search and we don't want them throwing a validation error saying I don't do search/ingest embeddings.
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Aug 18, 2025
This was referenced Aug 19, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Aug 19, 2025
(cherry picked from commit 1f9b6bb)
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Aug 19, 2025
(cherry picked from commit 1f9b6bb)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 19, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
internalInputTypevalues to the translation logic for EIS.I'm backporting this because the internal values were added in 8.19 and 9.1 from this PR: #122638