Update transport version directory structure #132891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Transport API
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
@elasticmachine run "elasticsearch-ci/8.18.6 / Part 3 / bwc-snapshots" |
rjernst
approved these changes
Aug 14, 2025
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
Looks good, a couple small nits
| String component, | ||
| String path, | ||
| boolean nameInFile, | ||
| boolean ignoreName, |
Member
There was a problem hiding this comment.
nit: maybe flip this to positive logic, like "recordName" or "captureName"?
Contributor
Author
There was a problem hiding this comment.
changed to isNamed
| + name | ||
| + "];" | ||
| + "\nknown names [" | ||
| + VersionsHolder.ALL_VERSIONS_BY_NAME |
Member
There was a problem hiding this comment.
do we want this permanently or was it only for debugging?
Contributor
Author
There was a problem hiding this comment.
I thought about keeping this at least until we are further along, but decided to remove it unless we need it again.
JVerwolf
approved these changes
Aug 14, 2025
| if (nameInFile) { | ||
| name = parts[0]; | ||
| } else { | ||
| name = path.substring(path.lastIndexOf('/') + 1, path.length() - 4); |
Contributor
There was a problem hiding this comment.
Optional: I'm not a fan of "magic numbers" (4) here or elsewhere, I'd rather this reference a constant if only purely to improve readability and maintainability. Not blocking - your call.
Contributor
Author
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-3 |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 15, 2025
This changes the directory structure for transport version files to the following: /transport/latest /transport/definitions/named /transport/definitions/initial /transport/definitions/manifest.txt This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest. ES-12401
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 15, 2025
This changes the directory structure for transport version files to the following: /transport/latest /transport/definitions/named /transport/definitions/initial /transport/definitions/manifest.txt This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest. ES-12401
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 15, 2025
This changes the directory structure for transport version files to the following: /transport/latest /transport/definitions/named /transport/definitions/initial /transport/definitions/manifest.txt This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest. ES-12401
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 15, 2025
This changes the directory structure for transport version files to the following: /transport/latest /transport/definitions/named /transport/definitions/initial /transport/definitions/manifest.txt This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest. ES-12401
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 15, 2025
This changes the directory structure for transport version files to the following: /transport/latest /transport/definitions/named /transport/definitions/initial /transport/definitions/manifest.txt This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest. ES-12401
This was referenced Aug 15, 2025
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Aug 18, 2025
This changes the directory structure for transport version files to the following: /transport/latest /transport/definitions/named /transport/definitions/initial /transport/definitions/manifest.txt This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest. ES-12401
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2025
* Update transport version directory structure (#132891) This changes the directory structure for transport version files to the following: /transport/latest /transport/definitions/named /transport/definitions/initial /transport/definitions/manifest.txt This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest. ES-12401 * fix gitignore * remove extraneous newline * remove extraneous initial file * revert initial change * migrate ml_rollover_legacy_indices transport version (#133008)
rjernst
pushed a commit
that referenced
this pull request
Aug 19, 2025
This changes the directory structure for transport version files to the following: /transport/latest /transport/definitions/named /transport/definitions/initial /transport/definitions/manifest.txt This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest. ES-12401
rjernst
pushed a commit
that referenced
this pull request
Aug 19, 2025
This changes the directory structure for transport version files to the following: /transport/latest /transport/definitions/named /transport/definitions/initial /transport/definitions/manifest.txt This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest. ES-12401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the directory structure for transport version files to the following:
This allows manifest to be placed in a location for named and initial transport versions without adding confusion to latest.
ES-12401