Skip to content

[8.19] DocValuesConsumerUtil tweak #132901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

[8.19] DocValuesConsumerUtil tweak #132901

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c8228a
DocValuesConsumerUtil tweak (#132586)
martijnvg Aug 11, 2025
6fe1ef9
Merge remote-tracking branch 'es/8.19' into backport_132586_to_8.19
martijnvg Aug 16, 2025
f40c9de
Merge remote-tracking branch 'es/8.19' into backport_132586_to_8.19
martijnvg Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/DocValuesConsumerUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,20 +64,29 @@ static MergeStats compatibleWithOptimizedMerge(boolean optimizedMergeEnabled, Me
if (entry != null) {
sumNumValues += entry.numValues;
sumNumDocsWithField += entry.numDocsWithField;
} else {
assert false : "unexpectedly got no entry for field [" + fieldInfo.number + "\\" + fieldInfo.name + "]";
return UNSUPPORTED;
}
}
case SORTED_NUMERIC -> {
var entry = tsdbDocValuesProducer.sortedNumerics.get(fieldInfo.number);
if (entry != null) {
sumNumValues += entry.numValues;
sumNumDocsWithField += entry.numDocsWithField;
} else {
assert false : "unexpectedly got no entry for field [" + fieldInfo.number + "\\" + fieldInfo.name + "]";
return UNSUPPORTED;
}
}
case SORTED -> {
var entry = tsdbDocValuesProducer.sorted.get(fieldInfo.number);
if (entry != null) {
sumNumValues += entry.ordsEntry.numValues;
sumNumDocsWithField += entry.ordsEntry.numDocsWithField;
} else {
assert false : "unexpectedly got no entry for field [" + fieldInfo.number + "\\" + fieldInfo.name + "]";
return UNSUPPORTED;
}
}
case SORTED_SET -> {
Expand All @@ -90,6 +99,9 @@ static MergeStats compatibleWithOptimizedMerge(boolean optimizedMergeEnabled, Me
sumNumValues += entry.ordsEntry.numValues;
sumNumDocsWithField += entry.ordsEntry.numDocsWithField;
}
} else {
assert false : "unexpectedly got no entry for field [" + fieldInfo.number + "\\" + fieldInfo.name + "]";
return UNSUPPORTED;
}
}
case BINARY -> {
Expand All @@ -98,6 +110,9 @@ static MergeStats compatibleWithOptimizedMerge(boolean optimizedMergeEnabled, Me
sumNumDocsWithField += entry.numDocsWithField;
minLength = Math.min(minLength, entry.minLength);
maxLength = Math.max(maxLength, entry.maxLength);
} else {
assert false : "unexpectedly got no entry for field [" + fieldInfo.number + "\\" + fieldInfo.name + "]";
return UNSUPPORTED;
}
}
default -> throw new IllegalStateException("unexpected doc values producer type: " + fieldInfo.getDocValuesType());
Expand Down