Temp cuvs load fixes #132928
Closed
Temp cuvs load fixes #132928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| static void loadCuvs() { | ||
| var libCuvs = SymbolLookup.libraryLookup(System.mapLibraryName("cuvs_c"), Arena.ofAuto()); | ||
| LogManager.getLogger(NativeAccess.class).info("Loaded libcuvs_c.so: " + libCuvs); |
Contributor
There was a problem hiding this comment.
This solely for logging / debugging purposes, right? And if cuVS is not present then null or something is printed? (which is fine)
ChrisHegarty
approved these changes
Aug 14, 2025
Contributor
Author
|
I'll keep this open/as a draft in case we need this. But since we now know why and how we can work around the root cause, I'm not merging it right away (and we might just close it eventually). |
Contributor
Author
|
Closed as we have a better workaround, plus ongoing conversation with nvidia for long-term fix of C++ dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a temporary fix to our troubles loading cuvs after
NativeAccessis initialized, this PR contains a workaround to pre-load it during bootstrap.It also contains a fix for the initialization of the cluster used for YAML rest tests, where we propagate the
LD_LIBRARY_PATHenvironment variable.