Adds Cluster Balance Stats Tests #132936
Merged
Adds Cluster Balance Stats Tests #132936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds serialization tests for `ClusterBalanceStats.MetricStats` and `ClusterBalanceStats.TierBalanceStats`
joshua-adams-1
added
>non-issue
:Distributed Coordination/Distributed
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
…-1/elasticsearch into cluster-balance-stats-tests
Contributor
Author
|
I added these tests during #131025 but didn't commit them to avoid bloating the PR. Adding them now as they're useful |
ywangd
approved these changes
Aug 19, 2025
Comment on lines
47
to
52
| double total = randomDouble(); | ||
| double min = randomDouble(); | ||
| double max = randomDouble(); | ||
| double average = randomDouble(); | ||
| double stdDev = randomDouble(); | ||
| ClusterBalanceStats.MetricStats stats = new ClusterBalanceStats.MetricStats(total, min, max, average, stdDev); |
Member
There was a problem hiding this comment.
Nit: I think these can be replaced by calling createRandomMetricStats() and the later assertions can compare with stats.total() etc?
Comment on lines
55
to
66
| ClusterBalanceStats.MetricStats shardCount = createRandomMetricStats(); | ||
| ClusterBalanceStats.MetricStats undesiredShardAllocations = createRandomMetricStats(); | ||
| ClusterBalanceStats.MetricStats forecastWriteLoad = createRandomMetricStats(); | ||
| ClusterBalanceStats.MetricStats forecastDiskUsage = createRandomMetricStats(); | ||
| ClusterBalanceStats.MetricStats actualDiskUsage = createRandomMetricStats(); | ||
| ClusterBalanceStats.TierBalanceStats tierBalanceStats = new ClusterBalanceStats.TierBalanceStats( | ||
| shardCount, | ||
| undesiredShardAllocations, | ||
| forecastWriteLoad, | ||
| forecastDiskUsage, | ||
| actualDiskUsage | ||
| ); |
Member
There was a problem hiding this comment.
Similar nit: this can be replaced by createRandomTierBalanceStats()?
pabloem
pushed a commit
to pabloem/elasticsearch
that referenced
this pull request
Aug 22, 2025
Adds serialization tests for `ClusterBalanceStats.MetricStats` and `ClusterBalanceStats.TierBalanceStats`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds serialization tests for
MetricStatsTestsandTierBalanceStatsTestsRelated to #131025