Skip to content

test: fix SparseVectorFieldMapperTests edge case #132937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 19, 2025
Merged

test: fix SparseVectorFieldMapperTests edge case #132937

merged 10 commits into from
Aug 19, 2025
+52 −24

Conversation

@mromaios
Copy link
Contributor

@mromaios mromaios commented Aug 14, 2025 •
edited
Loading

Closes #132810
Follow up from: #132264

This PR:

  • Fixes an edge case test failure for when the index contains 2 segments
  • Adds additional indexVersions to test (v_8x coverage)
  • Unmutes the SparseVectorFieldMapperTest
  • Improves randomisation for indexVersions

@mromaios mromaios requested a review from Mikep86 August 14, 2025 15:25
@mromaios mromaios self-assigned this Aug 14, 2025
@mromaios mromaios added >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI :SearchOrg/Relevance Label for the Search (solution/org) Relevance team labels Aug 14, 2025
@elasticsearchmachine elasticsearchmachine added Team:SearchOrg Meta label for the Search Org (Enterprise Search) needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Search - Relevance The Search organization Search Relevance team v9.2.0 labels Aug 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@mromaios mromaios removed >test-failure Triaged test failures from CI needs:risk Requires assignment of a risk label (low, medium, blocker) labels Aug 14, 2025
Mikep86
Mikep86 reviewed Aug 14, 2025
View reviewed changes
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks investigating and implementing the fix! I left one material comment about how we're getting index versions, other than that we're good

@mromaios mromaios requested review from kderusso and markjhoy August 15, 2025 11:45
This was referenced Aug 15, 2025
Merged
Merged
kderusso
kderusso approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending clean CI

Mikep86
Mikep86 approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mromaios mromaios merged commit fe44a4d into elastic:main Aug 19, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mikep86 Mikep86 Mikep86 approved these changes

@kderusso kderusso kderusso approved these changes

@markjhoy markjhoy Awaiting requested review from markjhoy

Assignees

@mromaios mromaios

Labels

:SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] SparseVectorFieldMapperTests testPruningScenarios failing

4 participants

@mromaios @elasticsearchmachine @Mikep86 @kderusso