[ML] Disable child span for streaming tasks #132945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
|
Hi @prwhelan, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
This was referenced Aug 18, 2025
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Aug 18, 2025
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Aug 18, 2025
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Aug 18, 2025
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Aug 18, 2025
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2025
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2025
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2025
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2025
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 18, 2025
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream. In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is the potential for a memory leak, depending on which thread handles the onComplete message. Currently, the child span does not add anything to debugging, so we will disable it until we can figure out a clean way to propagate the child span's context throughout the stream.
In any case, it would be better to replace it entirely with a child span capturing the outbound service call and response for both streaming and non-streaming requests, so this may remain disabled in the long run anyway in favor of that child span.