ESQL: Mark new signatures in MIN and MAX #132980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MIN` and `MAX` functions support unsigned longs in 9.2.0. The docs just show it's that unsigned long is supported but you can't tell for what version. This fixes that, applying the version. The version table is generated from the tests. So we have to annotate some test cases with `applies_to` and pass it through the test infrastructure.
elasticsearchmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
commented
Aug 15, 2025
| | long | long | | ||
| | text | keyword | | ||
| | unsigned_long | unsigned_long | | ||
| | unsigned_long{applies_to}`stack: ga 9.2.0` | unsigned_long | |
Member
Author
There was a problem hiding this comment.
The actual generated changes look like this
| /** This test generates documentation for the supported output types of the lookup join. */ | ||
| public void testOutputSupportedTypes() throws Exception { | ||
| Map<List<DataType>, DataType> signatures = new LinkedHashMap<>(); | ||
| Map<List<DocsV3Support.Param>, DataType> signatures = new LinkedHashMap<>(); |
Member
Author
There was a problem hiding this comment.
All of these s/DataType/DocsV3Support.Param/ exist so I can plumb FunctionAppliesTo information through the test case instead of an annotation. That's because we generate the type signatures entirely from test cases - no annotation to scan.
| Stream.of( | ||
| MultiRowTestCaseSupplier.intCases(1, 1000, Integer.MIN_VALUE, Integer.MAX_VALUE, true), | ||
| MultiRowTestCaseSupplier.longCases(1, 1000, Long.MIN_VALUE, Long.MAX_VALUE, true), | ||
| MultiRowTestCaseSupplier.ulongCases(1, 1000, BigInteger.ZERO, UNSIGNED_LONG_MAX, true), |
Member
Author
There was a problem hiding this comment.
This is the actual fix - moving the signatures from here to below with appliesTo(FunctionAppliesToLifecycle.GA, "9.2.0", "", true) stuck to them.
Member
Author
|
This renders like: |
leemthompo
reviewed
Aug 18, 2025
| | long | long | | ||
| | text | keyword | | ||
| | unsigned_long | unsigned_long | | ||
| | unsigned_long{applies_to}`stack: ga 9.2.0` | unsigned_long | |
Contributor
There was a problem hiding this comment.
total hygiene nit: I wonder if we'd want a whitespace here before the {applies_to}s ?
Again hope this wasn't too painful to wire up 😿
bpintea
approved these changes
Aug 18, 2025
| if (functionAppliesTos.length > 0) { | ||
| appliesToText.append("```{applies_to}\n"); | ||
| if (false == functionAppliesTos.isEmpty()) { | ||
| appliesToText.append(oneLine ? "{applies_to}`" : "```{applies_to}\n"); |
Contributor
There was a problem hiding this comment.
This would make the difference, as well as tick openings more obvious. But I guess the compact one-liner will do too.
Suggested change
| appliesToText.append(oneLine ? "{applies_to}`" : "```{applies_to}\n"); | |
| if (oneLine) { | |
| appliesToText.append("{applies_to}"); | |
| appliesToText.append("`"); | |
| } else { | |
| appliesToText.append("```"); | |
| appliesToText.append("{applies_to}"); | |
| } |
Member
Author
There was a problem hiding this comment.
If it makes it easier for you to read, I'm happy to do it.
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 19, 2025
…improv * upstream/main: (92 commits) ESQL: mark LOOKUP JOIN as ExecutesOn.Any by default (elastic#133064) Fix 404s in REST API landing page (elastic#133086) Fix release tests for OptimizerVerificationTests (elastic#133100) Make Glob non-recursive (elastic#132798) Update ES|QL function list for release versions (elastic#133096) Split transport version func test into abstract base (elastic#133035) Omit project ID from snapshot metrics (elastic#133098) Mute org.elasticsearch.xpack.esql.analysis.AnalyzerTests testNoDenseVectorFailsForMagnitude elastic#133013 Mute org.elasticsearch.xpack.esql.optimizer.OptimizerVerificationTests testRemoteEnrichAfterCoordinatorOnlyPlans elastic#133015 Mute org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT test {p0=search/160_exists_query/Test exists query on _id field} elastic#133097 Rename initial to unreferenced in transport versions (elastic#133082) Rename exception type header (elastic#133045) ESQL: Pluggable tests for Operator status (elastic#132876) ESQL: Mark new signatures in MIN and MAX (elastic#132980) Don't try to serialize half-baked cluster info (elastic#132756) migrate ml_rollover_legacy_indices transport version (elastic#133008) Enable `exclude_source_vectors` by default for new indices (elastic#131907) Expose APIs needed by flush during translog replay (elastic#132960) Change reporting_user role to leverage reserved kibana privileges (elastic#132766) Update TasksIT for batched execution (elastic#132762) ...
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 19, 2025
* upstream/main: (58 commits) ESQL: mark LOOKUP JOIN as ExecutesOn.Any by default (elastic#133064) Fix 404s in REST API landing page (elastic#133086) Fix release tests for OptimizerVerificationTests (elastic#133100) Make Glob non-recursive (elastic#132798) Update ES|QL function list for release versions (elastic#133096) Split transport version func test into abstract base (elastic#133035) Omit project ID from snapshot metrics (elastic#133098) Mute org.elasticsearch.xpack.esql.analysis.AnalyzerTests testNoDenseVectorFailsForMagnitude elastic#133013 Mute org.elasticsearch.xpack.esql.optimizer.OptimizerVerificationTests testRemoteEnrichAfterCoordinatorOnlyPlans elastic#133015 Mute org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT test {p0=search/160_exists_query/Test exists query on _id field} elastic#133097 Rename initial to unreferenced in transport versions (elastic#133082) Rename exception type header (elastic#133045) ESQL: Pluggable tests for Operator status (elastic#132876) ESQL: Mark new signatures in MIN and MAX (elastic#132980) Don't try to serialize half-baked cluster info (elastic#132756) migrate ml_rollover_legacy_indices transport version (elastic#133008) Enable `exclude_source_vectors` by default for new indices (elastic#131907) Expose APIs needed by flush during translog replay (elastic#132960) Change reporting_user role to leverage reserved kibana privileges (elastic#132766) Update TasksIT for batched execution (elastic#132762) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MINandMAXfunctions support unsigned longs in 9.2.0. The docs just show it's that unsigned long is supported but you can't tell for what version. This fixes that, applying the version.The version table is generated from the tests. So we have to annotate some test cases with
applies_toand pass it through the test infrastructure.