-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Prefetch PostingList #133009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Prefetch PostingList #133009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
john-wagster
commented
Aug 18, 2025
server/src/main/java/org/elasticsearch/index/codec/vectors/DefaultIVFVectorsWriter.java
Show resolved
Hide resolved
iverase
reviewed
Aug 18, 2025
server/src/main/java/org/elasticsearch/index/codec/vectors/DefaultIVFVectorsReader.java
Outdated
Show resolved
Hide resolved
iverase
reviewed
Aug 18, 2025
server/src/main/java/org/elasticsearch/index/codec/vectors/IVFVectorsReader.java
Outdated
Show resolved
Hide resolved
iverase
reviewed
Aug 18, 2025
server/src/main/java/org/elasticsearch/index/codec/vectors/DefaultIVFVectorsReader.java
Outdated
Show resolved
Hide resolved
iverase
reviewed
Aug 18, 2025
server/src/main/java/org/elasticsearch/index/codec/vectors/DefaultIVFVectorsReader.java
Show resolved
Hide resolved
…search into low_memory_prefetch
iverase
approved these changes
Aug 19, 2025
Contributor
iverase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is a pity the extra long required but it is not too bad and it makes easy to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>non-issue
:Search Relevance/Search
Catch all for Search Relevance
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring prefetching the next posting list in the context of low memory scenarios. We get a good speed up with this approach in low memory scenarios.
Had to tweak how I was testing a good bit. Ultimately something akin to this that limits container ram and swap. 550m seemed to be the limit where a java command would run and 450mb was about the smallest heap given dbpedia 1m as the dataset:
docker stub command
Here's a couple of the runs for comparison of with and without prefetch:
Results